Skip to content

Refactored list data structure type annotations for compatibility with Python 3.8 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seperman merged 1 commit into from
May 6, 2025
Merged

Refactored list data structure type annotations for compatibility with Python 3.8 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions orderly_set/sets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ def index(self, value: Hashable) -> int:
except ValueError:
raise KeyError(value)

def indexes(self, keys: list[Hashable]) -> list[int]:
def indexes(self, keys: List[Hashable]) -> List[int]:
return [self.index(subkey) for subkey in keys]

# Provide some compatibility with pd.Index
Expand Down Expand Up @@ -962,7 +962,7 @@ def update(self, sequence: SetLike[T]) -> int:
def index(self, value: Hashable) -> int:
return self._map[value]

def indexes(self, keys: list[Hashable]) -> list[int]:
def indexes(self, keys: List[Hashable]) -> List[int]:
return [self._map[key] for key in keys]

def pop(self, index: int = -1) -> T:
Expand Down Expand Up @@ -1237,7 +1237,7 @@ def index(self, key: Hashable) -> Any:
except ValueError:
raise KeyError(key)

def indexes(self, keys: list[Hashable]) -> list[int]:
def indexes(self, keys: List[Hashable]) -> List[int]:
return [self.index(subkey) for subkey in keys]

# Provide some compatibility with pd.Index
Expand Down