[INFRA] libc++ CI #236
Merged
[INFRA] libc++ CI #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 19 19
Lines 719 719
=======================================
Hits 689 689
Misses 30 30 ☔ View full report in Codecov by Sentry. |
eseiler
force-pushed
the
infra/libc++
branch
from
4f7605e to
948bcba
Compare
eseiler
force-pushed
the
infra/libc++
branch
from
948bcba to
82da8a5
Compare
Bins have same cardinality, but sort_by_cardinalities is not stable, hence order is implementation-defined
eseiler
force-pushed
the
infra/libc++
branch
from
82da8a5 to
485576e
Compare
smehringer
approved these changes
Dec 5, 2023
| @@ -66,8 +74,7 @@ jobs: | |||
| mkdir build | |||
| cd build | |||
| cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \ | |||
| -DCMAKE_CXX_FLAGS="-Werror -Wno-interference-size" \ | |||
| -DCHOPPER_NATIVE_BUILD=OFF | |||
There was a problem hiding this comment.
why is -DCHOPPER_NATIVE_BUILD=OFF removed completely?
There was a problem hiding this comment.
It is there because the ci sometimes crashed because of illegal instruction.
But this doesn't seem to happen anymore :)
| @@ -321,6 +321,104 @@ TEST(execute_test, many_ubs) | |||
| "#LOWER_LEVEL_IBF_26 fullest_technical_bin_idx:0\n" | |||
| "#LOWER_LEVEL_IBF_27 fullest_technical_bin_idx:0\n" | |||
| "#USER_BIN_IDX\tTECHNICAL_BIN_INDICES\tNUMBER_OF_TECHNICAL_BINS\n" | |||
| #ifdef _LIBCPP_VERSION // seqan::hibf::sketch::toolbox::sort_by_cardinalities is not stable | |||
There was a problem hiding this comment.
but it is deterministic within the same compiler?
what a code bloat 😓
There was a problem hiding this comment.
It's deterministic/constitent within each stl (libc++/libstdc++).
The alternative would be to use:
std::ranges::stable_sortin the HIBF method, but this has a potentially higher complexity, and also needs additional memory- make each size distinct. E. G. 200,201,202,..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.