Calculate active regions based on Cigar information #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 96.48% 96.80% +0.31%
==========================================
Files 19 19
Lines 797 814 +17
==========================================
+ Hits 769 788 +19
+ Misses 28 26 -2
Continue to review full report at Codecov.
|
joergi-w
requested review from
a team and
remyschwab
and removed request for
a team
joshuak94
requested changes
Oct 21, 2021
joshuak94
approved these changes
Oct 21, 2021
Irallia
requested changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the activity values from a previous PR to calculate the regions of high activity with a sliding window approach. The regions are returned in the format of intervals (i.e. pairs of genome positions).
The first commit adds the new functionality, the second commit structures the already quite long function into smaller, testable functions. The third commit adds API tests in order to satisfy coverage tests. Therefore, it may be easier to review them separately.
Resolves #153.