[FIX] Readd removed if case #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 98.39% 98.40%
=======================================
Files 18 18
Lines 874 875 +1
=======================================
+ Hits 860 861 +1
Misses 14 14
Continue to review full report at Codecov.
|
joergi-w
approved these changes
Jul 20, 2022
Comment on lines
-29
to
-31
| chr1 267 . N <DEL> 3 PASS END=285;SVLEN=-18;iGenVar_SVLEN=-18;SVTYPE=DEL GT ./. | ||
| chr1 283 . N <DEL> 3 PASS END=298;SVLEN=-15;iGenVar_SVLEN=-15;SVTYPE=DEL GT ./. | ||
| chr1 509 . N <DEL> 1 PASS END=528;SVLEN=-19;iGenVar_SVLEN=-19;SVTYPE=DEL GT ./. |
There was a problem hiding this comment.
Were these deletions incorrect?
There was a problem hiding this comment.
Yes, they came from other SV types:
Double Translocation ref: (266, 282] translocated after 286
Duplication in reference and read covered by SA tag ref: (509, 527] with copynumber=5
Signed-off-by: Lydia Buntrock <[email protected]>
Irallia
force-pushed
the
FIX/readd_removed_if
branch
from
0dde7db to
3cd2375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake when calling INVs. I accidentally deleted one if case too many.
With the new benchmarks, I then noticed on the plot that something is not right.
It was:
and now it is: