Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Put SDSL into contrib #3334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Feb 7, 2025

Creates an amalgamated version of sdsl in contrib and removes dependency on the sdsl repo.

  • sdsl-v3 is neither maintained nor widely packaged, the includes and namespaces clash with the more widely packages sdsl-v2
  • Because of that, we vendor/ship the sdsl anyway when building packages
  • After this change, we can switch to using find_package for cereal and have a somewhat mainstream CMake way of handling dependencies
  • Even though the header is 1 MB big, shipping the sdsl include directory takes 2 MB. A checkout of the sdsl is 5 MB. seqan3 checkout grows from 18 to 19 MB, the include from 5 to 6 MB.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 7, 2025
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 7, 2025
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3334

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (ee18011) to head (34bc3da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3334   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         270      270           
  Lines       11913    11913           
  Branches      104      104           
=======================================
  Hits        11688    11688           
  Misses        225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants