Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSN-28]: update dependencies and CI #21

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Conversation

pabloaledo
Copy link

@pabloaledo pabloaledo commented Jan 15, 2025

This PR gets some useful updates from the project https://github.com/wings-software/cloudinfo and also updates all dependencies for the go dependencies

@pabloaledo pabloaledo force-pushed the udpate_dependencies branch 4 times, most recently from a50f882 to c5e568c Compare January 15, 2025 14:36
Signed-off-by: Pablo <[email protected]>
@pabloaledo pabloaledo marked this pull request as ready for review January 15, 2025 15:42
@pabloaledo pabloaledo changed the title get updates from wings-software/cloudinfo update dependencies and CI Jan 15, 2025
@pabloaledo pabloaledo changed the title update dependencies and CI [FSN-28]: update dependencies and CI Jan 15, 2025
Copy link

@stefanoboriero stefanoboriero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -10,7 +10,7 @@ on:
pull_request:

env:
GO_VERSION: 1.16
GO_VERSION: 1.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it not be updated to the latest Go 1.23?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this when I want to update dependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated go in d07fdfd

Regarding the tool, it provides some dependency updates that were missing. I didn't update all because some of them gave compilation errors. Some of this problems have been solved by updating go version, but for gqlgen, alibaba-cloud-sdk-go, viper, gqlparser and the google-api I still can not compile using the latest version 🤷‍♂️ . Should I investigate this further?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to spend more time if it gives problems; Go 1.22 is good for now.

Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
@pabloaledo pabloaledo merged commit bf06374 into master Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants