-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata.namespace to K8s YAML files #133
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Why? |
@gwright99 requested this: See https://seqera.atlassian.net/browse/EDU-126 |
I see, but this would lock down the namespace name in the manifest file. As a customer, I want to be able to use my own namespace. This means those manifests will not be usable anymore to any customer (without prior editing) |
@pditommaso, completely agree. |
IMO, it's better to have the namespace explicitly defined in the manifests. This makes the key explicit, does not require the operator to remember to switch their With that said, this is not a hill I'm willing to die on. If there's opposition to the change, just leave it as is and push more cognitive load back onto the user deploying. The first K8s Installation step in the docs says to create a namespace, so maybe that is sufficient in itself. |
I leave it to you if keeping or no. My tip if keeping it:
|
I've looked and looked, but manually setting the namespace in K8s resources is not standard practice that I can see. Splitting the difference here makes it more work for K8s beginners and experts alike. Either switching to the target namespace, as we have in the docs, or executing Could elaborate in Create a namespace on why the namespace matters and how to confirm that you're in the correct namespace before starting, and that if you don't specify, the |
I really like this suggestion. For point 2, I would add a sentence to the line about creating a namespace that indicates "The manifests provided include the identifier @pditommaso, would you say this is a breaking change for customers who are revisiting this page and copying the manifest which now would include an additional field? That definitely is a concern and if this is a regular occurrence I would add an admonition that if an error is encountered, to check the namespace. |
Not sure it should be classified as breaking change, the important this is highlighting the need to change the namespace with a real one |
So regardless, a user still has to create the secret in the correct namespace, which is the first step. Creating a namespace and switching to that namespace context.
For every other step, five separate section steps, we need to remind the user to replace I think this is adding unnecessary to complexity to the Kubernetes deployment. |
This is a reasonable point. If it's not standard practice and will bloat our docs - and lead to customer confusion - I would recommend not moving ahead with this change. It's definitely something we can keep an eye on to ensure we adjust if needed. |
platform_versioned_docs/version-24.1.1/enterprise/kubernetes.mdx
Outdated
Show resolved
Hide resolved
@pditommaso, I've revised this to clarify the purpose of the namespace. If this looks okay, I can merge it. Thanks! |
platform_versioned_docs/version-24.1.1/enterprise/kubernetes.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
Fixed some typos, renamed the namespaces mentioned, and resolved conflicts. This is ready to merge. Thank you @pditommaso for your input! |
This PR adds
namespace: seqera-nf
to the K8s YAML files.