Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default env var for DE #15

Merged
merged 12 commits into from
Jul 23, 2024
Merged

Update default env var for DE #15

merged 12 commits into from
Jul 23, 2024

Conversation

justinegeffen
Copy link
Contributor

Updates default environment variables for data explorer for enterprise customers.

@justinegeffen
Update default env var for DE
f583393 
Updates default environment variables for data explorer for enterprise customers. 

Signed-off-by: Justine Geffen <[email protected]>
@justinegeffen justinegeffen marked this pull request as ready for review April 5, 2024 12:26
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit fceb54e
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/669ffda56053680008b19235
😎 Deploy Preview https://deploy-preview-15--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justinegeffen justinegeffen added 1. Editor review Needs a language review 1. Dev/PM/SME Needs a review by a Dev/PM/SME labels Apr 5, 2024
@justinegeffen
Copy link
Contributor Author

@ShahzebMahmood, @llewellyn-sl: gentle reminder on this PR. Thank you!

@justinegeffen
Copy link
Contributor Author

@ShahzebMahmood, reminder on this please. :)

@justinegeffen
Copy link
Contributor Author

@llewellyn-sl, when you have a moment, please could you review this. Thanks!

@justinegeffen justinegeffen requested a review from jimmypoms July 9, 2024 18:08
llewellyn-sl
llewellyn-sl previously requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@llewellyn-sl llewellyn-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true? I seem to recall the latest release being default true. Either way, we need to include 24.1.1 docs for this too, if a change is needed there.

@justinegeffen
Copy link
Contributor Author

Is this still true? I seem to recall the latest release being default true. Either way, we need to include 24.1.1 docs for this too, if a change is needed there.

Just checked the env vars doc and it supports this change but have also checked with data team.

@justinegeffen
Copy link
Contributor Author

@jimmypoms, ping for a review. Thank you!

@justinegeffen justinegeffen dismissed llewellyn-sl’s stale review July 23, 2024 19:28

changes implemented

@justinegeffen justinegeffen merged commit c405d6b into master Jul 23, 2024
5 checks passed
@justinegeffen justinegeffen deleted the justinegeffen-patch-1 branch July 23, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmypoms jimmypoms jimmypoms approved these changes

@ShahzebMahmood ShahzebMahmood Awaiting requested review from ShahzebMahmood

@llewellyn-sl llewellyn-sl Awaiting requested review from llewellyn-sl

Assignees
No one assigned
Labels
1. Dev/PM/SME Needs a review by a Dev/PM/SME 1. Editor review Needs a language review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinegeffen @jimmypoms @llewellyn-sl