Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Service Principal documentation #171

Merged
merged 51 commits into from
Oct 11, 2024
Merged

Azure Service Principal documentation #171

merged 51 commits into from
Oct 11, 2024

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Aug 15, 2024 •
edited
Loading

First draft of Azure Service Principal documentation (ticket).

I don't actually have permissions to test this so I would like to do a run through before I confirm it's OK.

Also includes some language tidying and removes the previous references to credentials.

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 56c9b3b
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/670962af5598b00008a694a1
😎 Deploy Preview https://deploy-preview-171--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamrtalbot adamrtalbot requested a review from swampie August 15, 2024 10:41
christopher-hakkaart
christopher-hakkaart previously requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments and suggestions. Most of them are clarity and consistency related. I'm not an expert in Azure so I can't comment on the content explicitly.

llewellyn-sl and others added 5 commits August 26, 2024 15:06
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
9dd8764 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
763fbb1 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
1791337 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
603c333 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @christopher-hakkaart
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
f63d1e9 
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@justinegeffen justinegeffen added 1. Editor review Needs a language review 1. Dev/PM/SME Needs a review by a Dev/PM/SME and removed 1. Dev/PM/SME Needs a review by a Dev/PM/SME labels Aug 30, 2024
@adamrtalbot adamrtalbot changed the title [WIP] Azure Service Principal documentation Azure Service Principal documentation Oct 7, 2024
@adamrtalbot
Copy link
Contributor Author

@llewellyn-sl @justinegeffen mind if we try and push this one over the line? it should be complete now.

justinegeffen
justinegeffen approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Adam! Looks great. Just a few comments but no major edits.

@justinegeffen
Copy link
Contributor

@adamrtalbot, if you're happy with my suggestions I'll commit them and merge this PR today. :)

llewellyn-sl and others added 5 commits October 11, 2024 19:14
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
44526e6 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
919d58c 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
88c2dbf 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
6fe50eb 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl @justinegeffen
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
105939e 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
llewellyn-sl
llewellyn-sl approved these changes Oct 11, 2024
View reviewed changes
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
a9b8d32 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
1009489 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
cbe5950 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
e09bd1f 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
7ea37db 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
7b2dc30 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
390e588 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
51c8266 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
d946b67 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
9bf74c0 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Update platform_versioned_docs/version-24.1/compute-envs/azure-batch.mdx
3de8eea 
Signed-off-by: Llewellyn vd Berg <[email protected]>
@llewellyn-sl
Merge branch 'master' into PLAT-330_Azure_docs
56c9b3b
@llewellyn-sl llewellyn-sl merged commit 606abbf into master Oct 11, 2024
6 checks passed
@llewellyn-sl llewellyn-sl deleted the PLAT-330_Azure_docs branch October 11, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinegeffen justinegeffen justinegeffen approved these changes

@mbosio85 mbosio85 mbosio85 approved these changes

@llewellyn-sl llewellyn-sl llewellyn-sl approved these changes

@swampie swampie Awaiting requested review from swampie

@christopher-hakkaart christopher-hakkaart Awaiting requested review from christopher-hakkaart

Assignees
No one assigned
Labels
1. Editor review Needs a language review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamrtalbot @justinegeffen @mbosio85 @christopher-hakkaart @llewellyn-sl