feat: impl From<[(K, V); N]> for Map and Value#938
Open
paul-soporan wants to merge 3 commits intoserde-rs:masterfrom
Open
feat: impl From<[(K, V); N]> for Map and Value#938paul-soporan wants to merge 3 commits intoserde-rs:masterfrom
From<[(K, V); N]> for Map and Value#938paul-soporan wants to merge 3 commits intoserde-rs:masterfrom
Conversation
martin-g
reviewed
Oct 17, 2022
martin-g
left a comment
There was a problem hiding this comment.
The PR does not have any unit tests.
Author
|
I'm new to writing tests in Rust so I apologize if the answer is obvious: From what I could find, it seems like this crate doesn't have any existing unit tests, but only integration tests and documentation tests. The example I added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
From<[(K, V); N]>forMapandValue, enabling things like:or
Relevant PRs:
impl From<[(K, V); N]> for HashMap(and friends) rust-lang/rust#84111 implemented it for the collections instdIndexMap::from(array)andIndexSet::from(array)indexmap-rs/indexmap#205 implemented it forIndexMap