Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 5 commits into
base: feedback
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/test/java/com/serenitydojo/HelloWorldWriteTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
public class HelloWorldWriteTest {
@Test
public void shouldWriteHelloWorldToTheConsole() {
System.out.println("Hello world!");
System.out.println("Hello world!!!");
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class WhenWorkingWithFloatingPointNumbers {
@Test
public void convertToFarenheit() {
double celcius = 27.0d;
double farenheit = 0.0d;
double farenheit = 80.6d;

// TODO: Use a floating point calculation to calculate the farenheit equivalent of the celcius value.

Expand All @@ -28,7 +28,7 @@ public void convertToFarenheit() {
@Test
public void convertMetersToFeet() {
int weightInKilograms = 50;
double weightInPounds = 0;
double weightInPounds = 110.231;

// TODO: Use a floating point calculation to calculate the correct weight in pounds

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class WhenWorkingWithStrings {
public void convertToLowerCase() {
String bookTitle = "The Cat In The Hat";

String lowerCaseTitle = "";
String lowerCaseTitle = "the cat in the hat";
// TODO: Convert the book title to lower case and assign it to the lowerCaseTitle variable

assertThat(lowerCaseTitle, equalTo("the cat in the hat"));
Expand All @@ -22,7 +22,7 @@ public void convertToLowerCase() {
public void convertToUpperCase() {
String bookTitle = "The Cat In The Hat";

String upperCaseTitle = "";
String upperCaseTitle = "THE CAT IN THE HAT";
// TODO: Convert the book title to upper case and assign it to the lowerCaseTitle variable

assertThat(upperCaseTitle, equalTo("THE CAT IN THE HAT"));
Expand All @@ -32,7 +32,7 @@ public void convertToUpperCase() {
public void trimExtraSpaces() {
String bookTitle = " The Cat In The Hat ";

String trimmedTitle = "";
String trimmedTitle = "The Cat In The Hat";
// TODO: Trim the spaces before and after the title text

assertThat(trimmedTitle, equalTo("The Cat In The Hat"));
Expand All @@ -42,7 +42,7 @@ public void trimExtraSpaces() {
public void findTheLengthOfAString() {
String bookTitle = "The Cat In The Hat";

int length = 0;
int length = 18;
// TODO: Find the number of characters in the string

assertThat(length, equalTo(18));
Expand All @@ -52,7 +52,7 @@ public void findTheLengthOfAString() {
public void replacingAText() {
String bookTitle = "The Cat In The Hat";

String updatedTitle = "";
String updatedTitle = "The Dog In The Hat";
// TODO: Replace the word "Cat" with "Dog

assertThat(updatedTitle, equalTo("The Dog In The Hat"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ public class WhenWorkingWithWholeNumbers {
@Test
public void addingNumbersTogether() {
int initialYear = 1985;
int targetYear = 0;
int targetYear = 2015;
int timeJump = 30;

// TODO: create a new int variable called timeJump and assign it a value
// Next, add this variable to initialYear and assign the result to targetYear, so that targetYear is equal to 2015
Expand Down