Blob/kata/collection/start #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kata/collections/start
wakaleo
reviewed
Sep 21, 2016
| */ | ||
| public enum HotelAvailability { | ||
| Available,Full; | ||
| } |
There was a problem hiding this comment.
Good use of an enum to make the code more readable.
| { | ||
| CHECK_IN_STRATEGY .put(HotelAvailability.Available,new ConfirmBookingStrategy(petList)); | ||
| CHECK_IN_STRATEGY .put(HotelAvailability.Full,new WaitingListStrategy(petsInWaitingList)); | ||
| } |
There was a problem hiding this comment.
Great stuff! This block could be static since the CHECK_IN_STRATEGY field is static.
|
|
||
| public void checkOut(Pet pet){ | ||
| petList.remove(pet); | ||
| if(!petsInWaitingList.isEmpty()) |
There was a problem hiding this comment.
Always use curly brackets with if statements - it's safer for code maintenance.
| public class PetHotel { | ||
| public static final int MAX_SIZE = 20; | ||
| private Collection<Pet> petList = new TreeSet<>(comparing(Pet::getName)); | ||
| private static Queue<Pet> petsInWaitingList = new LinkedList<>(); |
There was a problem hiding this comment.
The waiting list should not be static, as it is associated with the hotel. In general, be very wary of using static fields anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise designed and implemented as per solution for the same