Add port configuration #32
Conversation
There was a problem hiding this comment.
this looks basically plausible to me – thanks! it will probably be a while before I get around to merging/testing/publishing an update, but it's on my to-do list.
do you know if there's any way we can display any information about which Discord instance we're connected to? e.g. does the READY payload we receive contain any information that differs between release and PTB apps? I presume there's not, but it would be nice to know for sure one way or the other
| public void ReconnectDiscord() { | ||
| this.Connection.Dispose(); | ||
| this.Connection = new DiscordConnection(this); | ||
| this.disposeActions.Push(() => this.Connection.Dispose()); |
There was a problem hiding this comment.
this will cause this.Connection to be disposed multiple times, right? since the constructor already pushes one of these.
There was a problem hiding this comment.
I wasn't sure if the pushed one still works after replacing this.Connection with a new instance of DiscordConnection. I presumed it would not since the reference that was pushed into the stack points to a no-longer used instance of DiscordConnection. But i might be totally of the mark
|
There is a way to distinguish the instances. It's even logged into /xllog. It's part of the string you get when establishing the connection. The "api_endpoint" contains the url which is |
This isn't exactly what's described in #8 but it's a working solution for me. I run DiscordPtb (beta client) alongside the normal Discord client. And of course it usually tries to connect to the wrong one.
This lets me specifically set the port the websocket uses.
Added a number input to choose the port, with a big tooltip.
Along with a button to reconnect and a small label showing if its connected or not.
I also added a subcommand
/whostalking port <number>.If you are interested, but want some changes please let me know. If you are not I would still appreciate a heads-up so I'm aware.
Thank you for the amazing plugin!