Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventBridge Scheduler Integration for Stepfunction #571

Closed
jappurohit041 opened this issue May 22, 2023 · 10 comments · Fixed by #580 or #591
Closed

EventBridge Scheduler Integration for Stepfunction #571

jappurohit041 opened this issue May 22, 2023 · 10 comments · Fixed by #580 or #591
Labels

Comments

@jappurohit041
Copy link
Contributor

Feature Proposal

For feature proposals:
-> Ability to create AWS::Scheduler::Schedule triggers as an alternative to AWS::Event::Rule, which may be preferable if hitting account-wide limits on a number of AWS::Event::Rule triggers per bus (Lambdas are only able to be triggered from the default bus).
-> Also, specify a timezone to run it on local time.

@jappurohit041
Copy link
Contributor Author

jappurohit041 commented May 22, 2023

Please follow the work for the same in the following repository:
https://github.com/distinction-dev/serverless-step-functions/tree/feat-schedule-eventbridge

@jappurohit041 jappurohit041 changed the title EventBridge Scheduler Integeration EventBridge Scheduler Integration for Stepfunction May 22, 2023
@ayhamdewan
Copy link

Is there any update on adding this feature?

@KillDozerX2
Copy link

We have the first version ready, but unfortunately our previous PR into main here was not merged, hence we're a bit stuck and we may have to cherry-pick.
@lopburny can you guys check out this PR

@danmactough
Copy link
Contributor

This is an essential enhancement to this plugin to maintain parity with Serverless. See serverless/serverless#11935

@jappurohit041 @KillDozerX2 Can you make your PR to this repository so it can have a chance of getting merged and released?

@KillDozerX2
Copy link

This is an essential enhancement to this plugin to maintain parity with Serverless. See serverless/serverless#11935

@jappurohit041 @KillDozerX2 Can you make your PR to this repository so it can have a chance of getting merged and released?

Yeah, getting there.

@KillDozerX2
Copy link

This is an essential enhancement to this plugin to maintain parity with Serverless. See serverless/serverless#11935

@jappurohit041 @KillDozerX2 Can you make your PR to this repository so it can have a chance of getting merged and released?

Apologies for the delay, we've opened a new PR for this. #580

@jappurohit041
Copy link
Contributor Author

Hii @horike37 @lopburny,

Could we please have look at this issue, as it has been opened since very long and we have PR ready to implement this?

Thanks

@horike37
Copy link
Collaborator

🎉 This issue has been resolved in version 3.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jeffreydmohler
Copy link

Hi @KillDozerX2, @jappurohit041, @horike37

It seems like there is a key piece that was missed here. There is no way to pass input into the target. There are no errors when an input is passed, but when deployed, it never gets set.

Serverless allows for this functionality with Lambdas (see here)

Cloudformation also allows for this pretty simply (see here)

I imagine this was just missed or overlooked when adding this new code (see here) because errors were added for InputPath and InputTransformer.

Can this issue be re-opened for this functionality to be added?

@horike37
Copy link
Collaborator

🎉 This issue has been resolved in version 3.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants