Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Schedules using Eventbridge Scheduler #580

Conversation

KillDozerX2
Copy link

Fixes #571

@jappurohit041
Copy link
Contributor

Hii @horike37 @lopburny,

Could we please have look at this PR, as it has been opened since very long and it is kind of important to make it in sync with Serverless serverless/serverless#11935 ?

Thanks

@horike37
Copy link
Collaborator

@jappurohit041
Thank you for this PR. Looks good to me, seeing the added code and test that checks if the required parameters are given from serverless.yml.

Have you done actual tests for this feature? I mean like if this feature doesn't introduce any side effects to existing features, or if this keeps backward compatibility. Because I couldn't have enough time to check it.

If so, I will merge this PR and release it after you fix some linting errors.

@jappurohit041
Copy link
Contributor

Hii @horike37,

I have fixed lint issue, and due to the distinct logical ID, two test failed, so fixed the test case.

Also, I have done the actual tests for this feature, after the latest commit, and it is not breaking.

Working as expected😄

@horike37 horike37 merged commit ce5261a into serverless-operations:master Sep 15, 2023
@horike37
Copy link
Collaborator

🎉 This PR is included in version 3.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventBridge Scheduler Integration for Stepfunction
5 participants