Migration to Astro #220
Migration to Astro #220
Conversation
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
There was a problem hiding this comment.
Looks solid! Two Qs though:
- Why removing
.githubfiles? - Is this how the new website looks like? https://deploy-preview-220--serverlessworkflow.netlify.app/ Or maybe it's mixing the old files? 🤔
I didn't mean to, I'll readd them, good catch.
Kind of but it seems broken ATM (missing padding, bad alignments and so on), I must admit I open this PR in a rush because I was late for something else. I'll fix this tomorrow.
I looks like it was deployed properly but I'll remove them too. |
- readded .github folder - changed netlify.toml indentation - fixed usage of dynamic Tailwind class not being present in the css output Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
|
@JBBianchi would it be possible to add the logo left to the headers title, too? What fo you guys think? |
- added SW logo in the header - renamed favicons folder to icons and fixed manifest/browserconfig - added svg logo Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
|
Hey now it looks fantastic! Great work, @JBBianchi Just one nitpick, the logo seems not vertically aligned with the title: |
- Added a "star our GitHub Repo" CTA above the footer - Links and buttons are now "accent" - Other minor style changes Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
It should be better now. I also added a call to action above the footer for people to give a star and other little changes. |
There was a problem hiding this comment.
I might have to change RHT logo: https://www.redhat.com/en/about/brand/standards/logo
I can do it in a follow-up PR.
Thanks again, JB! This work looks awesome. Way better than what I did! hahaha
I can do it, no worries. You already did a great job, I'm just building on top ;) |
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
|
Oh that's so nice what you did!
|
|
@JBBianchi @ricardozanini let's merge? |
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
This PR migrate the website building technologies from Hugo/Docsy to Astro.
It adds a bit of complexity in the templating but we have full control over the output.
Special notes for reviewers:
Astro comes with an additional layer specifically designed for documentation, similar to how Docsy works for Hugo: Starlight.
At first glance, it offers a simpler and more user-friendly template for creating documentation, but at the cost of abstracting certain aspects (like routing, content configuration, etc.). If we decide to create documentation in the future, we have a few options: we can use the vanilla version, which would require implementing some features ourselves (such as "previous/next" buttons at the bottom of the page or a Table of Contents); we can deploy a separate website using Starlight; or we could port the current version to Starlight, which might involve some challenges with its preconfigured routing and other built-in settings.
Additional information (if needed):