Skip to content

Add optional SDK path arg to the build.sh #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janeoa wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add optional SDK path arg to the build.sh #127

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa0dfec
Add optinal SDK path arg to the build.sh
janeoa May 4, 2026
69df396
Add explicit message for build.sh SDK-path
janeoa May 4, 2026
7e5452e
Add exit if specified file does not exist
janeoa May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,54 @@

set -eu

COMMANDLINE_TOOLS_PATH="https://repo.huaweicloud.com/harmonyos/ohpm/5.1.0/commandline-tools-linux-x64-5.1.0.840.zip"
STAGED_COMMANDLINE_TOOLS_PATH=

usage() {
echo "Usage: $0 [--sdk-path PATH]"
}

while [[ "$#" -gt 0 ]]
do
case "$1" in
--sdk-path)
if [[ "$#" -lt 2 ]]
then
echo "Missing value for --sdk-path" >&2
usage >&2
exit 1
fi
COMMANDLINE_TOOLS_PATH="$2"
shift 2
;;
-h|--help)
usage
exit 0
;;
*)
echo "Unknown argument: $1" >&2
usage >&2
exit 1
;;
esac
done

cleanup() {
if [[ -n "${STAGED_COMMANDLINE_TOOLS_PATH}" && -f "${STAGED_COMMANDLINE_TOOLS_PATH}" ]]
then
rm -f "${STAGED_COMMANDLINE_TOOLS_PATH}"
fi
}

trap cleanup EXIT

if [[ -f "${COMMANDLINE_TOOLS_PATH}" ]]
then
STAGED_COMMANDLINE_TOOLS_PATH="hos_commandline_tools/.commandline-tools.zip"
cp "${COMMANDLINE_TOOLS_PATH}" "${STAGED_COMMANDLINE_TOOLS_PATH}"
COMMANDLINE_TOOLS_PATH=".commandline-tools.zip"
fi

SERVO_GIT_HASH=$(git ls-remote https://github.com/servo/servo.git --branches refs/heads/main | awk '{ print $1}')
GITHUB_ACTIONS_RUNNER_VERSION="2.334.0"
MITMPROXY_VERSION="12.2.1"
Expand All @@ -22,7 +70,8 @@ docker build gh_runner -f gh_runner/Dockerfile -t "servo_gha_runner:${GITHUB_ACT
--build-arg=USERNAME=${IMAGE_USERNAME} \
--build-arg=GITHUB_ACTIONS_RUNNER_VERSION=${GITHUB_ACTIONS_RUNNER_VERSION}
docker build hos_commandline_tools -f hos_commandline_tools/Dockerfile -t "hos_commandline_tools" \
--build-arg=USERNAME=${IMAGE_USERNAME}
--build-arg=USERNAME=${IMAGE_USERNAME} \
"--build-arg=COMMANDLINE_TOOLS_PATH=${COMMANDLINE_TOOLS_PATH}"

# Build the actual images

Expand Down