Update derive_more to v2.0.0 #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of fbd6a14 Signed-off-by: Oriol Brufau <[email protected]>
Needed for slotchange events Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Keith Cirkel <[email protected]>
…#109) When we are trying to interpolate two values that can't be interpolated according to the animation type of the CSS property, CSS animations should always fall back to discrete interpolation, and CSS transitions should also do so when `transition-behavior` is `allow-discrete`. Signed-off-by: Oriol Brufau <[email protected]>
A property may have an animation type different than 'discrete', but still not be able to interpolate some values. In that case animations fall back to discrete interpolation, but transitions can only do so if allowed by `transition-behavior`. We were already handling that well, but we were still triggering `transitionstart` events even if no transition ended up happening. This patchs prevents the creation of the transition, and simplifies a bunch of code since we no longer need to check whether the transition is allowed while the transition runs. Signed-off-by: Oriol Brufau <[email protected]>
This way the callers don't have to clone it if they don't have ownership or want to use the value later. Signed-off-by: Oriol Brufau <[email protected]>
This updates `derive_more` to the most recent version. The main reason I'm interested in doing this is so that the latest version will become available on the Rust Playground. The `derive_more` crate is being pulled due to selectors, but it pulls in an outdated version due to selectors depending on that version.
|
In general we try to not diverge from upstream if possible. |
|
Thanks for the pointer. I submitted it here now: https://phabricator.services.mozilla.com/D236782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
derive_moreto the most recent version. The main reasonI'm interested in doing this is so that the latest version will become
available on the Rust Playground. The
derive_morecrate is beingpulled due to selectors, but it pulls in an outdated version due to
selectors depending on that version.
See additional information here: rust-lang/rust-playground#1133