Derive Clone on SourceSize and SourceSizeList - #440
Merged
Conversation
All members of these classes already derive/implement Clone, so this is trivial. Required for cloning an HTMLLinkElement's source set when constructing LinkProcessingOptions. Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
lumiscosity
changed the title
clone on SourceSize and SourceSizeListClone on SourceSize and SourceSizeList
jdm
approved these changes
Aug 10, 2026
Member
|
We should submit this upstream as well, since it's a type that's shared with Gecko. |
Member
AbdAlRahmanGad
pushed a commit
to AbdAlRahmanGad/servo
that referenced
this pull request
Aug 14, 2026
Companion Stylo PR: servo/stylo#440 Implements source set operations on the `<link>` element. Testing: 4 new passing in `preload`, attribute tests on idlharness pass. --------- Signed-off-by: lumiscosity <averyrudelphe@gmail.com> Co-authored-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All members of these structs already derive/implement Clone, so this is trivial. Required for cloning an HTMLLinkElement's source set when constructing LinkProcessingOptions.