Repository navigation
Enable justify-items:legacy propagation for Servo - #482
Conversation
|
Yes, it was added for this purpose, but it's not suitable for it. See w3c/csswg-drafts#11463
|
|
Ah, maybe we can just close this then. It affects like 3 subtests. They just happen to be 3 that would take Blitz to 100% coverage of a particular WPT subsuite which was the main reason I was pursuing this. |
|
It may still make sense if it's not going to be removed soon. What are the tests, is Servo affected too? |
|
It's the ones Blitz doesn't pass here: https://blitz.is/wpt/css/css-align/default-alignment |
Loirooriol
left a comment
There was a problem hiding this comment.
I guess as long as legacy is supported, it's better to do it as the spec currently says, so feel free to reopen this.
Loirooriol
left a comment
There was a problem hiding this comment.
Please prepare the Servo PR with the new test expectations
2e4effe to
3d083b8
Compare
This value was added for implementing the legacy
<center>andalignattribute. Unlike otherjustify-itemsit inherits. Gecko, Servo, and Blitz all use the oldertext-align: -moz-leftsolution for that. But Gecko implements this property at style-level only. This PR simply implements that style adjustment for Servo builds as well.Makes a couple of
css-aligntests pass.Servo PR: servo/servo#48806