Skip to content

Enable justify-items:legacy propagation for Servo - #482

Merged
nicoburns merged 1 commit into
servo:mainfrom
nicoburns:justify-legacy
Oct 11, 2026
Merged

nicoburns merged 1 commit into
servo:mainfrom
nicoburns:justify-legacy

Conversation

@nicoburns

@nicoburns nicoburns commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

This value was added for implementing the legacy <center> and align attribute. Unlike other justify-items it inherits. Gecko, Servo, and Blitz all use the older text-align: -moz-left solution for that. But Gecko implements this property at style-level only. This PR simply implements that style adjustment for Servo builds as well.

Makes a couple of css-align tests pass.

Servo PR: servo/servo#48806

@Loirooriol

Copy link
Copy Markdown
Collaborator

Yes, it was added for this purpose, but it's not suitable for it. See w3c/csswg-drafts#11463

legacy needs to be removed, if allowed by web compat.

@nicoburns

Copy link
Copy Markdown
Collaborator Author

Ah, maybe we can just close this then. It affects like 3 subtests. They just happen to be 3 that would take Blitz to 100% coverage of a particular WPT subsuite which was the main reason I was pursuing this.

@nicoburns nicoburns closed this Oct 8, 2026
@Loirooriol

Copy link
Copy Markdown
Collaborator

It may still make sense if it's not going to be removed soon. What are the tests, is Servo affected too?

@nicoburns

Copy link
Copy Markdown
Collaborator Author

It's the ones Blitz doesn't pass here: https://blitz.is/wpt/css/css-align/default-alignment
Servo is also affected.

@Loirooriol Loirooriol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess as long as legacy is supported, it's better to do it as the spec currently says, so feel free to reopen this.

Comment thread style/properties/properties.mako.rs
@nicoburns nicoburns reopened this Oct 9, 2026

@Loirooriol Loirooriol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prepare the Servo PR with the new test expectations

@nicoburns
nicoburns added this pull request to the merge queue Oct 11, 2026
Merged via the queue into servo:main with commit c81cd9c Oct 11, 2026
5 checks passed
@nicoburns
nicoburns deleted the justify-legacy branch October 11, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants