Don't suppress combinations that map to an analog axis #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezanzeb
force-pushed
the
dont_suppress_analog
branch
from
efbce89 to
51e811e
Compare
This was referenced Feb 2, 2025
Merged
|
After updating the issue no longer occurs. I can bind combos to 2 axis and additional buttons without errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1046
_create_hierarchy_handlershas one key inhandlers: BTN_EXTRA.The analog input is omitted because of the
rank_bymethod of theCombinationHandler.This maps to a set containing the two combinations above. No HierarchyHandler is created, and both
combinations can be activated simultaneously.
As soon as this combination is added, the
_create_hierarchy_handlershas two keys in handlers.This causes
len(combinations_with_event)to be > 1, and therefore creates aHierarchyHandler.The
HierarchyHandlersuppresses combination 2.I adjusted the
HierarchyHandlerto not suppress combinations 1 and 2.