-
Notifications
You must be signed in to change notification settings - Fork 104
Issue #1 - Inconsistent Sidebar Styles: FIX #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
<% sidebar.archives.each do |month| %> | ||
<!-- ##ERROR WITH ARTICLE COUNT --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this added for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My b. I meant to delete this prior to committing.
This was meant to be used for my own purposes. I'm commenting ##ERROR
so I can find where I left off should I accidentally close a tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, if you can just take it out first.
Please remove |
@@ -73,6 +73,7 @@ gem 'recaptcha', require: 'recaptcha/rails', branch: 'rails3' | |||
gem 'rubypants', '~> 0.2.0' | |||
gem 'twitter', '~> 5.14.0' | |||
gem 'uuidtools', '~> 2.1.1' | |||
gem 'psych', '~> 2.0', '>= 2.0.17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you need to add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I cleared the error messages from terminal, but on rake db:create
, I was given ~25 lines of errors related to NOT having psych as a gem. Once added, the errors were resolved and allowed me to create, migrate and seed the database.
… stay consistent with other <ul>s on the page
Nice work! 👍 |
fixes #1 |
Changed the classes of the divs to render consistent styling with other sidebar items.