Skip to content

Issue #1 - Inconsistent Sidebar Styles: FIX #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Issue #1 - Inconsistent Sidebar Styles: FIX #16

wants to merge 5 commits into from

Conversation

jroers
Copy link

@jroers jroers commented Feb 5, 2016

Changed the classes of the divs to render consistent styling with other sidebar items.

<% sidebar.archives.each do |month| %>
<!-- ##ERROR WITH ARTICLE COUNT -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this added for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My b. I meant to delete this prior to committing.

This was meant to be used for my own purposes. I'm commenting ##ERROR so I can find where I left off should I accidentally close a tab.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, if you can just take it out first.

@nathanallen
Copy link
Contributor

Please remove psych gem, or introduce a new issue to discuss its merits.

@@ -73,6 +73,7 @@ gem 'recaptcha', require: 'recaptcha/rails', branch: 'rails3'
gem 'rubypants', '~> 0.2.0'
gem 'twitter', '~> 5.14.0'
gem 'uuidtools', '~> 2.1.1'
gem 'psych', '~> 2.0', '>= 2.0.17'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you need to add this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I cleared the error messages from terminal, but on rake db:create, I was given ~25 lines of errors related to NOT having psych as a gem. Once added, the errors were resolved and allowed me to create, migrate and seed the database.

@nathanallen
Copy link
Contributor

Nice work! 👍

@jroers
Copy link
Author

jroers commented Feb 5, 2016

fixes #1
Removed Psych gem as requested, removed personal comment. Justified removal of archives id in <ul>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants