Skip to content

Assignments completed #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

DavidKim84
Copy link

Tried to attempt the bonus questions, but seemed to have trouble with both. The bonus question answer for the bottles seem to be close but I feel I am missing an argument/condition. Notes were left in both bonus question attempts. Please see notes. Palindrome script was worked in a group with whiteboarding and needed a google reference to sort out special characters. Assignments were at about a 3 for me but I believe the thought process of completion was gotten better.

@melicarls
Copy link
Contributor

  • Bottles of beer: Remember to wrap your code in a function! Your commented section if(bottles - 1 === 1) would handle the case where 'bottles' should be changed to 'bottle' in the second to last verse. Look at the solutions branch to see an implementation of this, as well as a solution where the starting number of bottles can be passed into the function.
  • Palindromes: Your use of Regex was great- we'll talk about that more in-depth when we begin learning Ruby.
    Great work overall! It's great that you're working with peers- keep it up if that's helpful to you.

@melicarls melicarls closed this Jul 6, 2016
@melicarls melicarls reopened this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants