Skip to content

w01 d01 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

w01 d01 #11

wants to merge 4 commits into from

Conversation

im-mattbrown
Copy link

comfort: 4/5
completeness: 4/5
So far I feel good since this is only our first week and I was able to get a good amount of the assignment done. Before this weeks lessons, I would have been stumped by these challenges for sure.

@melicarls
Copy link
Contributor

melicarls commented Jul 6, 2016

  • Bottles of beer: You could make this slightly more dry by consolidating the blocks that execute when (i===1).
  • isPrime: You can remove line 24 and line 25 can just read if (isPrime(i)) since isPrime() will always return a boolean.
  • isPalindrome: Great job handling edge cases like capitalization and special characters! We'll learn more concise ways of doing this later on in the class, but it's really great that you're thinking about these things now and addressing them in your code.

Awesome work overall! These are really solid solutions. I'm glad that you felt prepared to handle the problem set after the first week of class.

@melicarls melicarls closed this Jul 6, 2016
@melicarls melicarls reopened this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants