Skip to content

Javascript Basics Problem Set #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

danieloh91
Copy link

w01 d01

comfort: 3/5
completeness: 4/5
I thought the homework assignment was really challenging. It took me several hours over the course of the past 2 days to solve them but I'm glad that I feel like I grasped the concepts and was able to answer to the best of my abilities.

@melicarls
Copy link
Contributor

Nice job! Here are a few comments:

  • Bottles of beer: How could you make the starting number of bottles into a variable? Check out the solutions branch if you'd like to see an example of that stretch goal, but I think that you could do it with a bit more time! Also, the second to last verse will print out "1 bottle*s" when less===1. Could you use some if/else logic to fix that?
  • Palindromes: Your use of Regex was great- we'll talk about that more in-depth when we begin learning Ruby.
  • Shakespeare: you can (and should) declare your first, second, and third variables within the insultGenerator() function instead of the in the global scope. In this case, they won't need to be accessed outside of your function so it's considered a better practice to encapsulate them within the function. Take a look at the solutions branch for the bonuses.

@melicarls melicarls closed this Jul 7, 2016
@melicarls melicarls reopened this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants