Skip to content

Conversation

@hoevik
Copy link

@hoevik hoevik commented Jul 1, 2016

homework - first

@hoevik hoevik closed this Jul 1, 2016
@melicarls melicarls reopened this Jul 1, 2016
@melicarls
Copy link
Contributor

  • bottlesOfBeer: Nice work! Great job making the number of starting bottles variable. On line 31, when i-1===1, your function will console log "one bottle_s_ of beer on the wall." Could you use any if/else logic to fix that little issue?
  • isPalindrome: Your use of Regex was great- we'll talk about that more in-depth when we begin learning Ruby.
  • isPrime: Take a look at the solutions branch for this one. When you have an opportunity, revisit this problem and make an attempt at the primes(max) function.
  • Shakespeare: there's a small typo on line 24- 'nafirst' should be 'first.' Once that's fixed, this code runs perfectly.

Great job overall! You came up with some really solid solutions to these challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants