Skip to content

week 1 day 4 homework #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

week 1 day 4 homework #17

wants to merge 8 commits into from

Conversation

mxayon
Copy link

@mxayon mxayon commented Jul 1, 2016

Challenging homework but was able to get most code to work. Having a hard time attaching bonuses or other conditions into the function.

@melicarls
Copy link
Contributor

melicarls commented Jul 6, 2016

Great work! I have a couple of notes:

  • Bottles of beer: Watch your indentation and your variable names. Your code throws a few errors: you either need to stick with the plural numBottles or the singular numBottle throughout the entire function. Also, beer(1) would refer to a function beer(num). Your function would need to be called with song(1). Please take a look at the solutions branch for this one.
  • Shakespeare: Lines 21-23 aren't necessary in this case. Since you don't need to access any variables outside of your insult function, try to avoid declaring variables in the global scope.

As you learn more JS, you can always go back and try to tackle the bonuses as additional practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants