Skip to content

Finished problem set #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

tgrahams101
Copy link

Problem set was really challenging--really pushed me to think very critically about how to solve the problem.

A really challenging part was thinking about the process. How do I construct a functional process/execution flow that solves the parameters of the problems? What approach and methods would I use to construct it/inside the process?

Felt really awesome and refreshing when I was able to get the code to work and finally solve the problem. Felt cool to stretch my problem solving skills.

My comfort level of assignment (1 being impossible, 5 being a breeze) was a 2.

@melicarls
Copy link
Contributor

Great job, Ted! Here are a few notes:

  • Bottles of beer: Remember to wrap your code within a function declaration. Can you think of a way to allow the starting number of bottles to change based on a variable passed into the function when called?
  • Palindrome: If you replace line 33 with var theword= word.toLowerCase(), your function could allow for case insensitive palindrome detection. Take a look at the solutions branch for a couple of other approaches to this problem.
  • isPrime: You're using 0/1 as indicators of primeness. Can you replace 0/1 with true/false? Your function does the job, but boolean values would be more appropriate in this case.
  • Shakespeare: Please review the solutions branch on this one. Your code doesn't currently work for numbers less than 3. It's also important that the last word in the insult come from list finished assignment #3, since it needs to be a noun.

Great work overall! I'm glad that you took the time to attempt the stretch challenges. These problems could be a good opportunity to practice refactoring as you hone your JS skills!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants