fixes #1 sidebar styles #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lify_debugging_lab into fix_sidebar_styles merge with origin to be able to push
|
Fix irrelevant file changes--change sidebar classes to match existing classes |
|
Solution looks good. In the original comment, please add more detail about the specific code changes that fixed the issue. |
|
Fixes #1 <-- please use this syntax (see https://help.github.com/articles/closing-issues-via-commit-messages/) |
nathanallen
added
G2M - Great job!
Squash your commits (too messy!)
and removed
Please reference issue number in description
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1
` To : ` `I fixed the bug in the file _content.html.erb by renaming the h3 class from 'sidebar_title' to 'sidebar-title' to match an existing class with monospace font in the user-styles.css, and renaming the div class from 'sidebar_body' to 'sidebar-body' to match existing class with circle bullet style
Change from :
`