Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1: Sidebar Style Inconsistent #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tbduong
Copy link

@tbduong tbduong commented Sep 2, 2016

Issue #1: Sidebar style inconsistencies found within archives_sidebar/content view:

  • Sidebar title for "Archive" inconsistent with other titles within sidebar (incorrect font family ) --- corrected to monospace.
  • Sidebar list bullets inconsistent style --- corrected to all be circles.

Found that class names were entered incorrectly (e.g: "sidebar_title" should be "sidebar-title"). Issue resolved and classes renamed correctly. Sidebar Style corrected.

@tbduong
Copy link
Author

tbduong commented Sep 2, 2016

-Condense style changes: sidebar Archive and List style fixes changes occur in user-style.css.

}

.sidebar_title {
font-family: monospace;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces redundant CSS rules for styling the sidebar. Can we use existing rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants