FIXED Issue #1: Styling changes to sidebar #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +32,14 @@ img.right { | |||
| font-family: monospace; | |||
| } | |||
|
|
|||
| .sidebar_title { | |||
| font-family: monospace; | |||
There was a problem hiding this comment.
This PR introduces a redundant CSS rule for styling the sidebar title.
DavidKim84
changed the title
|
Original comment needs more description of the changes that fixed the issue |
DavidKim84
changed the title
melicarls
added
WHY does this fix it?
and removed
remove leading/trailing white space
labels
|
Good description of issues fixed, but what changes did you make to fix them? |
|
Where in the HTML did you make those changes? Be more specific. |
|
Filename is written incorrectly. It's _content.html.erb, not -content.html.erb. Change that and include the path to the file (lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED Issue #1: Inconsistent Sidebar Styles
All titles in the sidebar are consistent to Monospace.
All li bullets have been changed to circles within the sidebar.
class sidebar_title and class sidebar_body was shown in lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb
whereas
class sidebar-title and class sidebar-body was shown in user-styles.css
Replaced the _ to - within lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb to fix the sidebar issues
Original
FIxed