resolved issue #1 : fixed sidebar inconsistencies #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clean up the formatting in your comment a bit. I'm seeing a bunch of colons and a dash where there shouldn't be one. |
| @@ -17,7 +17,7 @@ def index | |||
| @statsdrafts = Article.drafts.where('created_at > ?', today).count | |||
| @statspages = Page.where('published_at > ?', today).count | |||
| @statuses = Note.where('published_at > ?', today).count | |||
| @statuserposts = Article.published.where('published_at > ?', today).count(conditions: { user_id: current_user.id }) | |||
| @statuserposts = current_user.articles.published.where('published_at > ?', today).count | |||
There was a problem hiding this comment.
How does this change relate to the sidebar styling issue?
There was a problem hiding this comment.
this was to troubleshoot admin error - couldn't load admin page earlier.. should've done this on separate branch!
There was a problem hiding this comment.
Can you push up another commit that reverts the changes?
melicarls
added
Squash your commits (too messy!)
and removed
unnecessary file changes
labels
nathanallen
added
G2M - Great job!
and removed
NOT YET APPROVED
Squash your commits (too messy!)
you're so close
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #1 - Inconsistent Sidebar Styles -
changed div and h3 class "sidebar_title / sidebar_body" to match css file class "sidebar-title / sidebar-body"
in file : lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb
<h3 class="sidebar_title"> to -> <h3 class="sidebar-title">and
<div class="sidebar_body"> to -> <div class="sidebar-body">