Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED ISSUE: (Sign-in form displays raw span html in input fields) #25

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+7 −7
Open

FIXED ISSUE: (Sign-in form displays raw span html in input fields) #25

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30961f9
changed class names for the h3 and div tag of the archives sidebar co…
tgrahams101 Sep 2, 2016
3ca54cb
top month always empty fix
tgrahams101 Sep 2, 2016
a159906
removed raw span html from devise signin(up) fields and replaced with…
tgrahams101 Sep 2, 2016
de1e2e6
revised input fields for internationalization
tgrahams101 Sep 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/devise/registrations/new.html.erb
View file
Original file line number Diff line number Diff line change
@@ -6,11 +6,11 @@
<%= devise_error_messages! %>

<div class="form-group">
<%= f.text_field :login, class: 'form-control', placeholder: t(".username"), autofocus: true %>
<%= f.text_field :login, class: 'form-control', placeholder: true, autofocus: true %>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publify platform needs to be useable by an international audience of non-english speakers. Please do not remove placeholder text!

</div>

<div class="form-group">
<%= f.email_field :email, class: 'form-control', placeholder: t('.email') %>
<%= f.email_field :email, class: 'form-control', placeholder: true %>
</div>

<div class="form-group">
4 changes: 2 additions & 2 deletions app/views/devise/sessions/new.html.erb
View file
Original file line number Diff line number Diff line change
@@ -5,11 +5,11 @@
<%= form_for(resource, as: resource_name, url: session_path(resource_name)) do |f| %>
<fieldset>
<div class="form-group">
<%= f.text_field :login, class: 'form-control', placeholder: t('.login'), autofocus: true %>
<%= f.text_field :login, class: 'form-control', placeholder: true, autofocus: true %>
</div>

<div class="form-group">
<%= f.password_field :password, class: 'form-control', placeholder: t('.password'), autocomplete: 'off' %>
<%= f.password_field :password, class: 'form-control', placeholder: true, autocomplete: 'off' %>
</div>

<div class="checkbox">
6 changes: 3 additions & 3 deletions lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<% unless sidebar.archives.blank? %>
<h3 class="sidebar_title"><%= sidebar.title %></h3>
<div class="sidebar_body">
<h3 class="sidebar-title"><%= sidebar.title %></h3>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this change relevant to the bug fix?

<div class="sidebar-body">
<ul id="archives">
<% sidebar.archives.each do |month| %>
<% counter = sidebar.show_count ? "<em>(#{month[:article_count]})</em>" : "" %>
<li>
<%= link_to"#{month[:name]} #{counter}".html_safe, articles_by_month_path( month[:year], "%02i" % (month[:month]+1) ) %>
<%= link_to"#{month[:name]} #{counter}".html_safe, articles_by_month_path( month[:year], "%02i" % (month[:month]) ) %>
</li>
<% end %>
</ul>