Fix #2 empty top month #36
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <h3 class="sidebar_title"><%= sidebar.title %></h3> | ||
| <div class="sidebar_body"> | ||
| <h3 class="sidebar-title"><%= sidebar.title %></h3> | ||
| <div class="sidebar-body"> |
There was a problem hiding this comment.
Are these changes relevant to the top month being empty?
mehgellan
force-pushed
the
fix_empty_month2
branch
from
2991a41 to
b4b2cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb --> removed +1 from articles_by_month_path to fix the off by one bug in the month links on the sidebar.
From:
<%= link_to"#{month[:name]} #{counter}".html_safe, articles_by_month_path( month[:year], "%02i" % (month[:month]+1) ) %>
To:
<%= link_to"#{month[:name]} #{counter}".html_safe, articles_by_month_path( month[:year], "%02i" % (month[:month]) ) %>
However, the routes are now off by one so that when I click on September, the url says /2016/08...