AWS deploy workflow#937
Open
aaronhans wants to merge 1 commit into
Open
Conversation
Contributor
|
This seems sensible to me but defer to Francis and others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the workflow I have been running to do deploys. It works with the OIDC provider we setup to provide deploy role so once we:
Anybody who runs this workflow can deploy to production.
Triggering
Right now this is a manual trigger, you click run workflow and enter the SHA. We could change this to run on new merge to main.
I'd like input from team on how we want to trigger this safely. Is merge to a protected branch fine?
Upgrades