fix incorrect price calculation in sf orders ls #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed price calculation logic in OrderDisplay.tsx, focusing on price per GPU hour calculations for order listings.
- Modified price calculation in
orderDetails()to divide price by (quantity * duration * GPUs) instead of multiplying first - Potential bug: Inconsistency between regular price and executed price calculations that could lead to incorrect values
- Edge case risk: Division by zero possible when duration is 0, currently handled by defaulting to 1 hour
- Consider using helper functions from
src/helpers/price.tsfor consistent price calculations across the codebase
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
12
to
+13
| const pricePerGPUHour = | ||
| (order.price * order.quantity) / GPUS_PER_NODE / durationInHours / 100; | ||
| order.price / (order.quantity * durationInHours * GPUS_PER_NODE) / 100; |
There was a problem hiding this comment.
logic: The price calculation for regular and executed prices are inconsistent. Regular price divides first while executed price multiplies first. This will give different results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.