fix: [ENG-1319] allow user to set explicit end time, round up end and duration to the nearest hour
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`parseStartDate` function
…ient `.POST` method
|
Review changes with Changed Files
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds explicit end time setting and duration rounding functionality to the CLI, focusing on order management and improving type safety with Deno.
- Added
-e/--endoption insrc/lib/buy/index.tsxthat conflicts with-d/--duration, ensuring exactly one is specified - Centralized date parsing in
src/helpers/units.tswith newparseStartDatefunction that handles both string and Date inputs - Removed redundant
orders_createendpoint fromsrc/helpers/urls.ts, suggesting order creation flow changes - Added compiler option
deno.nsindeno.jsonto support Deno's standard library features - Introduced coding guidelines in
.cursor/rules/cli.mdcfor consistent Node.js imports and API client usage
25 file(s) reviewed, 13 comment(s)
Edit PR Review Bot Settings | Greptile
sigmachirality
commented
Feb 16, 2025
Comment on lines
+112
to
+115
| export function parseStartDate(startDate?: string | Date): Date { | ||
| if (startDate instanceof Date) return startDate; | ||
| const result = parseStartDateOrNow(startDate); | ||
| return result === "NOW" ? new Date() : result; |
There was a problem hiding this comment.
In an ideal world this would be called like coerceStartDateToDate but this is a pedantic nit
…r to function call
Sladuca
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error where a user sets an explicit duration for a buy order, and it doesn't end on an hour boundary. Rounds the end time/duration up to the next hour boundary.