fix: error handling for beta service?

sgoodrow · Aug 3, 2024 · 44d7244 · 44d7244
1 parent 3bf26b6
commit 44d7244
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 52 deletions.
diff --git a/src/services/betaDkpService.ts b/src/services/betaDkpService.ts
@@ -20,29 +20,13 @@ client.interceptors.request.use((config) => {
   return config;
 });
 
-const handleError = (error: unknown) => {
-  if (axios.isAxiosError(error)) {
-    console.error(
-      "Beta error creating raid:",
-      error.response?.data || error.message
-    );
-  } else {
-    console.error("Beta error creating raid:", error);
-  }
-  throw error;
-};
-
 export const betaDkpService = {
   upsertRaidActivityType: async (name: string, defaultPayout: number) => {
-    try {
-      const response = await client.post<{ id: number }>(
-        "/api/v1/raid-activity-type/upsert",
-        { name, defaultPayout }
-      );
-      return response.data.id;
-    } catch (error) {
-      handleError(error);
-    }
+    const response = await client.post<{ id: number }>(
+      "/api/v1/raid-activity-type/upsert",
+      { name, defaultPayout }
+    );
+    return response.data.id;
   },
 
   createRaid: async ({
@@ -57,35 +41,31 @@ export const betaDkpService = {
       raidActivityType.defaultPayout
     );
 
-    try {
-      client.post("/api/v1/raid-activity", {
-        activity: {
-          typeId,
-          createdAt: new Date(raidTick.data.date),
-          payout: raidTick.data.value,
-          note: raidTick.note,
-        },
-        attendees: raidTick.data.attendees.map((name) => ({
-          characterName: name,
-          pilotCharacterName: name,
-        })),
-        adjustments: raidTick.data.adjustments?.map(
-          ({ player, value, reason }) => ({
-            characterName: player,
-            pilotCharacterName: player,
-            amount: value,
-            reason,
-          })
-        ),
-        purchases: raidTick.data.loot.map(({ buyer, item, price }) => ({
-          characterName: buyer,
-          pilotCharacterName: buyer,
-          amount: price,
-          itemName: item,
-        })),
-      });
-    } catch (error) {
-      handleError(error);
-    }
+    client.post("/api/v1/raid-activity", {
+      activity: {
+        typeId,
+        createdAt: new Date(raidTick.data.date),
+        payout: raidTick.data.value,
+        note: raidTick.note,
+      },
+      attendees: raidTick.data.attendees.map((name) => ({
+        characterName: name,
+        pilotCharacterName: name,
+      })),
+      adjustments: raidTick.data.adjustments?.map(
+        ({ player, value, reason }) => ({
+          characterName: player,
+          pilotCharacterName: player,
+          amount: value,
+          reason,
+        })
+      ),
+      purchases: raidTick.data.loot.map(({ buyer, item, price }) => ({
+        characterName: buyer,
+        pilotCharacterName: buyer,
+        amount: price,
+        itemName: item,
+      })),
+    });
   },
 };
diff --git a/src/services/castledkp.ts b/src/services/castledkp.ts
@@ -237,7 +237,12 @@ export const castledkp = {
         },
       })
       .catch((error) => {
-        console.log(`Failed to create raid in beta service: ${error}`);
+        console.error(`Failed to create raid in beta service:`, {
+          message: error.message,
+          statusCode: error.response ? error.response.status : "N/A",
+          data: error.response ? error.response.data : "N/A",
+          config: error.config,
+        });
       });
 
     return {