Making delegating cache helper/key members final

Signed-off-by: Sagar Upadhyaya <[email protected]>
sgup432 · Jan 2, 2024 · dc3f903 · dc3f903
1 parent 00091c3
commit dc3f903
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/server/src/main/java/org/opensearch/common/lucene/index/OpenSearchDirectoryReader.java b/server/src/main/java/org/opensearch/common/lucene/index/OpenSearchDirectoryReader.java
@@ -54,7 +54,7 @@ public final class OpenSearchDirectoryReader extends FilterDirectoryReader {
     private final ShardId shardId;
     private final FilterDirectoryReader.SubReaderWrapper wrapper;
 
-    private DelegatingCacheHelper delegatingCacheHelper;
+    private final DelegatingCacheHelper delegatingCacheHelper;
 
     private OpenSearchDirectoryReader(DirectoryReader in, FilterDirectoryReader.SubReaderWrapper wrapper, ShardId shardId)
         throws IOException {
@@ -86,8 +86,8 @@ public DelegatingCacheHelper getDelegatingCacheHelper() {
      * @opensearch.internal
      */
     public class DelegatingCacheHelper implements CacheHelper {
-        private CacheHelper cacheHelper;
-        private DelegatingCacheKey serializableCacheKey;
+        private final CacheHelper cacheHelper;
+        private final DelegatingCacheKey serializableCacheKey;
 
         DelegatingCacheHelper(CacheHelper cacheHelper) {
             this.cacheHelper = cacheHelper;
@@ -114,7 +114,7 @@ public void addClosedListener(ClosedListener listener) {
      *  object itself for serialization purposes.
      */
     public class DelegatingCacheKey {
-        private CacheKey cacheKey;
+        private final CacheKey cacheKey;
         private final String uniqueId;
 
         DelegatingCacheKey(CacheKey cacheKey) {