Allowing linux builds (Currently filenotfound exception) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Sep 9, 2023
| public static string UNITY3D_FUNCTION_DEFINATIONFILE = "Data" + Path.DirectorySeparatorChar.ToString() + "Unity3D_functions.def"; | ||
| public static string UNITY3D_KEYWORD_DEFINATIONFILE = "Data" + Path.DirectorySeparatorChar.ToString() + "Unity3D_keywords.def"; | ||
| public static string UNITY3D_MACROS_DEFINATIONFILE = "Data" + Path.DirectorySeparatorChar.ToString() + "Unity3D_macros.def"; | ||
| public static string UNITY3D_VALUES_DEFINATIONFILE = "Data" + Path.DirectorySeparatorChar.ToString() + "Unity3D_values.def"; |
There was a problem hiding this comment.
Maybe we can use Path.Combine here?
There was a problem hiding this comment.
Sounds good to me
|
I've published version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you are trying to run shader-ls in linux you get the error: Unhandled exception. System.IO.FileNotFoundException.
Assembly.GetExecutingAssembly().CodeBase was deprecated so, I changed the line to .Location. Which did seem to fix the issue of the file directory string doubling up on linux.
Also, I have modified the ShaderlabDataManager.cs to use "Path.DirectorySeparatorChar.ToString()", because linux uses the / instead of \
I converted it the consts to static instead of const because I'm am using that function instead, otherwise you would get the error "Constant initializer must be compile-time constant" I'm sure you could fix that with #ifdef, but I didn't want to look into it.
Feel free to reject this pull request to implement the changes in your own way.