[IMPROVEMENT/BUGFIX] Fix upserts on bulk inserts #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ON DUPLICATE KEYandON CONFLICTdoes not work for bulk inserts. If someone were to use the updates map to override values, it would override identically for all rows being upserted.To account for bulk inserts MySQL has `key` = VALUES(`key`) to get the insert value, and Postgres/SQLite has "key" = EXCLUDE."key".
SYNTAX ADDITION:
Instead of always requiring a key => value pair, you can also use just the identifier to put a
VALUES(key)orEXCLUDED.keyin the query.Will translate to
This way, the existing syntax still works and nothing is broken