Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade_to_zola_19 #83

Closed
wants to merge 2 commits into from
Closed

Upgrade_to_zola_19 #83

wants to merge 2 commits into from

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Jun 21, 2024

Wasn't sure what else was needed but gave it a go based on the commit I saw in the history

@Mikopet
Copy link

Mikopet commented Jun 27, 2024

This would be nice!

Also using perhaps 0.19.1 already?
@shalzz opinion?

@c-git
Copy link
Contributor Author

c-git commented Jun 27, 2024

Yeah if there is a newer version we should go to that. When I did the PR I did it to the latest version. But not sure if @shalzz has time to approve. So not sure updating the PR is worth it. But happy to update if desired.

@Mikopet
Copy link

Mikopet commented Jun 27, 2024

tbh it would be better to separate the action version number from zola version number, so everybody could just update it from ENV

@shalzz
Copy link
Owner

shalzz commented Jun 30, 2024

Superseded by 9c5ce0c

tbh it would be better to separate the action version number from zola version number, so everybody could just update it from ENV
It's not possible to build a docker image with GH actions env variables.

@shalzz shalzz closed this Jun 30, 2024
@Mikopet
Copy link

Mikopet commented Jun 30, 2024

It's not possible to build a docker image with GH actions env variables.

That's true, and because of that the overridden version (if not matching with the default baked-in version) could be acquired in the ENTRYPOINT, what can use ENVs and args.

@c-git c-git deleted the upgrade_to_zola_19 branch December 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants