Feat#195 글/댓글 신고 추가 #202
Merged
Feat#195 글/댓글 신고 추가 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls-rain
approved these changes
Jun 4, 2024
| @Builder | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @AllArgsConstructor | ||
| public class ReportCategory { |
There was a problem hiding this comment.
Enum을 사용하지 않고 클래스로 사용한 이유가 궁금합니다!
There was a problem hiding this comment.
실은 큰 차이는 없지만..
이전에 글(post) 관련해서도 category 엔티티를 사용해서 DB에 미리 항목을 저장해두고 관리했었는데,
신고 카테고리도 DB에서 직접 항목을 관리하는 식으로 통일하는 게 좋을 것 같아 엔티티로 만들었습니다!
카테고리 이름이나 종류에 변화가 필요할 때
enum으로 관리하면 코드를 수정한 후에 빌드를 다시 해야 하는데,
DB에다가 관리하면 테이블 내용만 수정해주면 바로 반영되어서 더 유동적인 느낌인 것 같다고 생각했습니다!
There was a problem hiding this comment.
유지보수에 용이하다는 뜻이군요! 감사합니다 ㅎㅎ!
|
Elastic Beanstalk 동작 확인 용으로 이 PR 닫겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가했습니다!
+) 이 과정에서 신고 카테고리를 담는
report_category테이블이 DB에 추가로 생성되었습니다!(근데 가끔씩 신고 api 실행할 때마다 report 테이블에 content랑 category 컬럼이 자동으로 생성되는데
(현재는 필요 없는데 예전에 존재했었던 컬럼)이 부분은 나중에 자세히 해결해보겠습니다..!!)