Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#95 #96

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Feat#95 #96

merged 6 commits into from
Feb 10, 2024

Conversation

jjjuhoon
Copy link
Collaborator

@jjjuhoon jjjuhoon commented Feb 9, 2024

No description provided.

@jjjuhoon jjjuhoon requested review from MinYeongPark, ls-rain and pswoo0323 and removed request for MinYeongPark and ls-rain February 9, 2024 19:53
@jjjuhoon jjjuhoon changed the base branch from main to develop February 9, 2024 19:54
@jjjuhoon jjjuhoon closed this Feb 9, 2024
@jjjuhoon jjjuhoon reopened this Feb 9, 2024
Copy link
Member

@MinYeongPark MinYeongPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation 처리 감사합니다! 저도 참고해서 반영해두겠습니다!

@@ -27,7 +27,11 @@ public class Card_poll extends BaseEntity {

@Column(nullable = true)
@Builder.Default
private Timestamp deadline= Timestamp.valueOf(LocalDateTime.now().plusHours(1)); // 디폴트 시간 1시간 설정.
private LocalDateTime deadline= LocalDateTime.now().plusHours(1); // 디폴트 시간 1시간 설정.
Copy link
Member

@MinYeongPark MinYeongPark Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분에서 deadline이 -9(UTC 차이) + 1시간인 값이 디폴트로 들어가게 되더라구요..!!

https://red-mimmu.tistory.com/105
이 글 참고해서 한번 서울로 시간 조정되도록 반영해보겠습니다! -> 반영한 커밋 하나 날렸습니다!

Copy link
Member

@MinYeongPark MinYeongPark Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Swagger에서 deadline에서 default로 뜨는 값도 LocalDateTime.now().plusHours(1); 으로 자동으로 뜨게 하고 싶었는데,, 여러 설정을 변경해봤지만 여기에서는 계속 UTC 시간으로 뜨네요,,

프론트분들이 보내주실 때는 값을 설정해서 주시게 되니까,, 그대로 진행해도 괜찮을 것 같습니다..!!😂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!!!

@MinYeongPark MinYeongPark merged commit df8dfd7 into develop Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants