Fixes requested in review

sharkdp · Jan 11, 2025 · 5212a97 · 5212a97
1 parent 76dd090
commit 5212a97
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -137,9 +137,12 @@ jobs:
           npm run vscode:package -- --out="${VSCE_PATH}"
           echo "VSCE_NAME=${VSCE_NAME}" >> $GITHUB_OUTPUT
           echo "VSCE_PATH=${VSCE_PATH}" >> $GITHUB_OUTPUT
-    outputs:
-      VSCE_NAME: ${{ steps.vsce-package.outputs.VSCE_NAME }}
-      VSCE_PATH: ${{ steps.vsce-package.outputs.VSCE_PATH }}
+      
+      - name: "Artifact upload: VSCode extension"
+        uses: actions/upload-artifact@master
+        with:
+          name: ${{ steps.vsce-package.outputs.VSCE_NAME }}
+          path: ${{ steps.vsce-package.outputs.VSCE_PATH }}
 
   build:
     name: ${{ matrix.job.target }} (${{ matrix.job.os }})
@@ -396,12 +399,6 @@ jobs:
       with:
         name: ${{ steps.debian-package.outputs.DPKG_NAME }}
         path: ${{ steps.debian-package.outputs.DPKG_PATH }}
-
-    - name: "Artifact upload: Debian package"
-      uses: actions/upload-artifact@master
-      with:
-        name: ${{ needs.vscode_extension_package.outputs.VSCE_NAME }}
-        path: ${{ needs.vscode_extension_package.outputs.VSCE_PATH }}
 
     - name: Check for release
       id: is-release

diff --git a/vscode-extension/package.json b/vscode-extension/package.json
@@ -1,5 +1,5 @@
 {
-    "name": "numbat-extension",
+    "name": "numbat-vscode-extension",
     "displayName": "Numbat",
     "description": "Syntax highlighting for the Numbat programming language",
     "version": "0.1.0",