Skip to content

Conversation

@L33Z22L11
Copy link
Contributor

Description

The transformerRenderIndentGuides from @shikijs/transformers previously only parsed the this.options.meta?.__raw string to get the indent value. This PR adds support for reading the pre-parsed this.options.meta?.indent configuration and optimizes the indent value validation logic (skips processing if the value is non-numeric('false') or ≤ 0).

Linked Issues

Additional context

@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 5b10930
🔍 Latest deploy log https://app.netlify.com/projects/shiki-matsu/deploys/6904b94dd671e300081cbd00
😎 Deploy Preview https://deploy-preview-1087--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 5b10930
🔍 Latest deploy log https://app.netlify.com/projects/shiki-next/deploys/6904b94d61333200084442e3
😎 Deploy Preview https://deploy-preview-1087--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.24%. Comparing base (b536e4d) to head (5b10930).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nsformers/src/transformers/render-indent-guides.ts 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
- Coverage   88.26%   88.24%   -0.03%     
==========================================
  Files          74       74              
  Lines        3290     3291       +1     
  Branches      943      945       +2     
==========================================
  Hits         2904     2904              
- Misses        341      344       +3     
+ Partials       45       43       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antfu antfu merged commit d8f8967 into shikijs:main Oct 31, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants