Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tgrs #30

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7a9f4db
make current TGRS work
psmithshine Jul 1, 2024
fbb21ec
- make mesage be a simple "Hello", instead of using "get"
psmithshine Jul 2, 2024
ffd26c7
🛰️ 🛰️ 🛰️ upgrade to Node v20 in server 🛰️ 🛰️ 🛰️
psmithshine Jul 2, 2024
147f315
- add @parcel/watcher package to support dep of latest GraphQL codege…
psmithshine Jul 2, 2024
38dc4fa
- update lambda code to new api
psmithshine Jul 3, 2024
871a02b
- prettier format with @ts-ignore, for correct request context parsing
psmithshine Jul 3, 2024
08ad5a5
- update shared deps and tsconfig to prep for client's Vite overhaul
psmithshine Jul 3, 2024
b2c68a5
⚛ ⚛ ⚛ upgrade to Node v20 and setup Vite in client ⚛ ⚛ ⚛
psmithshine Jul 4, 2024
3416fe2
- package.json giving the Node version, and preventing tools other th…
psmithshine Jul 4, 2024
fb3e5e6
made tests work as-is, because it seems the webserver isnt contacting…
psmithshine Jul 4, 2024
6cf135b
Got integration tests partially going again
bent Jul 8, 2024
86f4d90
Remove server tests
bent Jul 8, 2024
a7bd775
Remove client tests
bent Jul 8, 2024
7b4a761
Got full integration test going again
bent Jul 8, 2024
51df2b0
Re-added userRequired directive to schema
bent Jul 8, 2024
e5604fd
- remove ts-node (using tsx instead)
psmithshine Jul 9, 2024
ba73b26
- update generates config path to just be into src/ and update codege…
psmithshine Jul 9, 2024
6e6dcc6
- remove express.ts module as we now have more modern `@as-integratio…
psmithshine Jul 9, 2024
c58fb0f
- keep port as 4000
psmithshine Jul 11, 2024
ec72cd9
- dont fix Typescript version
psmithshine Jul 11, 2024
abb96ab
Upgrade Ubuntu version
bent Jul 14, 2024
34d0697
Merge branch 'upgrade-tgrs' of https://github.com/shinesolutions/tgrs…
bent Jul 14, 2024
e9caf3a
Upgrade Cypress Github Action
bent Jul 14, 2024
455b5eb
- set not-exact version
psmithshine Jul 18, 2024
e9b699d
- add cypress as devDep
psmithshine Jul 18, 2024
d608c88
remove cypress tests
psmithshine Jul 18, 2024
87702aa
Update build.yml
psmithshine Jul 31, 2024
363507d
Update build.yml
psmithshine Jul 31, 2024
47896a9
Update build.yml
psmithshine Jul 31, 2024
d16aba8
Update build.yml
psmithshine Jul 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
node_modules
node_modules

### Node ###
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.18.1
20.10.0
9 changes: 9 additions & 0 deletions packages/client/codegen.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
schema: ../server/src/schema.graphql
generates:
./src/shared/__generated__/:
preset: "client"
documents: ["src/**/*.{ts,tsx}"]
config:
strictScalars: true
scalars:
ID: string
2 changes: 1 addition & 1 deletion packages/client/env/localhost-4000.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"serverUri": "http://localhost:4000",
"serverUri": "http://localhost:2000",
"integrationAuthToken": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c"
}
16 changes: 4 additions & 12 deletions packages/client/public/index.html → packages/client/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,25 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<link rel="icon" href="./favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Web site created using create-react-app"
/>
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<link rel="apple-touch-icon" href="./logo192.png" />
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
-->
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<!--
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.

Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<link rel="manifest" href="./manifest.json" />
<title>React App</title>
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<script type="module" src="./src/index.tsx"></script>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.
Expand Down
31 changes: 24 additions & 7 deletions packages/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,37 @@
"name": "client",
"version": "0.1.0",
"private": true,
"type": "module",
"engines": {
"node": ">=20.0.0 <21.0.0",
"npm": "please-use-yarn",
"yarn": ">= 1.22.17"
},
"dependencies": {
"@apollo/client": "^3.4.16",
"@apollo/client": "^3.8.8",
"@testing-library/jest-dom": "^5.11.4",
"@testing-library/react": "^11.0.4",
"@testing-library/user-event": "^7.1.2",
"@types/jest": "^24.0.0",
"@types/lodash": "^4.14.162",
"@types/node": "^12.0.0",
"@types/react": "^17.0.33",
"@types/react": "^18.2.19",
"@types/react-dom": "^17.0.10",
"apollo": "^2.33.7",
"graphql": "^15.3.0",
"graphql": "16.6.0",
"jest-environment-jsdom-sixteen": "^1.0.3",
"json-typescript": "^1.1.2",
"lodash": "^4.17.20",
"msw": "^0.21.2",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-scripts": "4.0.3",
"shared": "*",
"typescript": "^4.4.4"
},
"scripts": {
"start": "./scripts/start.sh",
"build": "./scripts/build.sh",
"test": "./scripts/test.sh",
"codegen": "./scripts/codegen.sh"
"codegen": "graphql-codegen --config codegen.yml"
},
"eslintConfig": {
"extends": "react-app"
Expand All @@ -45,5 +49,18 @@
"last 1 safari version"
]
},
"devDependencies": {}
"devDependencies": {
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@graphql-codegen/cli": "^5.0.0",
"@graphql-codegen/client-preset": "4.3.2",
"@graphql-codegen/typescript": "^4.0.1",
"@vitejs/plugin-react": "^4.2.1",
"@vitejs/plugin-react-swc": "^3.5.0",
"graphql-constraint-directive": "^5.1.1",
"ts-jest": "^29.0.5",
"vite": "^5.0.10",
"vite-plugin-node-polyfills": "^0.17.0",
"vite-plugin-svgr": "^4.2.0",
"vite-tsconfig-paths": "^4.2.2"
}
}
2 changes: 1 addition & 1 deletion packages/client/scripts/build.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
set -o errexit
yarn codegen
react-scripts build
vite build
3 changes: 2 additions & 1 deletion packages/client/scripts/start.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
set -o errexit
yarn install
yarn codegen
react-scripts start
vite
11 changes: 5 additions & 6 deletions packages/client/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
import "./App.css";
import { gql, useQuery } from "@apollo/client";
import { AppQuery, AppQueryVariables } from "./__generated__/AppQuery";
import { Language } from "./__generated__/globalTypes";
import { Language } from "./shared/__generated__/graphql";

function App() {
const { data, loading, error } = useQuery<AppQuery, AppQueryVariables>(
gql`
const { data, loading, error } = useQuery(
gql(`
query AppQuery($language: Language!) {
personalizedGreeting(language: $language)
}
`,
`),
{
variables: {
language: Language.ENGLISH,
language: Language.English,
},
}
);
Expand Down
1 change: 0 additions & 1 deletion packages/client/src/react-app-env.d.ts

This file was deleted.

1 change: 1 addition & 0 deletions packages/client/src/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/// <reference types="vite/client" />
17 changes: 9 additions & 8 deletions packages/client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,25 @@
"src"
],
"compilerOptions": {
"target": "es5",
"target": "ESNext",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"types": ["vite/client", "vite-plugin-svgr/client"],
"allowJs": false,
"skipLibCheck": true,
"allowSyntheticDefaultImports": true,
"module": "esnext",
"noEmit": true,
"jsx": "react-jsx",
"allowJs": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"strict": true,
"noFallthroughCasesInSwitch": true
"noEmit": true,
"noFallthroughCasesInSwitch": true,
"jsx": "react-jsx",
}
}
28 changes: 28 additions & 0 deletions packages/client/vite.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react-swc";
import viteTsconfigPaths from "vite-tsconfig-paths";
import svgr from "vite-plugin-svgr";
import { nodePolyfills } from "vite-plugin-node-polyfills";

// https://vitejs.dev/config/
export default defineConfig({
base: "/",
plugins: [
react(),
viteTsconfigPaths(),
svgr({
include: "**/*.svg?react",
}),
nodePolyfills({
globals: {
process: "build",
},
}),
],
build: {
outDir: "./build",
},
server: {
port: 3000,
},
});
9 changes: 6 additions & 3 deletions packages/integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
"serve-handler": "^6.1.3",
"server": "*",
"stubby": "^5.0.0",
"ts-node": "^9.0.0",
"typescript": "^4.0.3"
"tsx": "^4.6.2",
"typescript": "4.9.5"
},
"scripts": {
"start": "ts-node ./scripts/start",
"start": "tsx ./scripts/start",
"startStubby": "stubby --data ./src/stubbyData.yml"
},
"devDependencies": {
"ts-node": "^10.9.2"
}
}
9 changes: 5 additions & 4 deletions packages/integration/scripts/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ import {
} from "../src";

(async function () {
const stubbyServer = await startStubby({
targetPort: ephemeralPort,
});
// const stubbyServer = await startStubby({
// targetPort: ephemeralPort,
// });
const ep = {hostname: "127.0.0.1", port: 0}; //hardcoded, as the above doesnt work

const graphQlServerEndpoint = (
await startGraphQlServer({
targetPort: ephemeralPort,
stubbyEndpoint: stubbyServer.endpoint,
stubbyEndpoint: ep,
})
).endpoint;

Expand Down
26 changes: 15 additions & 11 deletions packages/integration/src/startGraphQlServer.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { startApolloServer } from "../../server";
import { startLocalApolloServer } from "../../server";
import { TargetPort } from "./TargetPort";
import { RunningServer } from "./RunningServer";
import { getRunningServer } from "./getRunningServer";
import { Endpoint } from "./Endpoint";
import { getRunningServer } from "./getRunningServer";
// import { getRunningServer } from "./getRunningServer";

/**
* Starts an instance of the GraphQL server that can be used for integration
Expand All @@ -18,23 +19,26 @@ export async function startGraphQlServer({
const name = "GraphQL Server";
console.log(`${name}: Starting...`);

const { server } = await startApolloServer(
const server = await startLocalApolloServer(
{
messageServerUrl: `http://${stubbyEndpoint.hostname}:${stubbyEndpoint.port}`,
},
{ host: "127.0.0.1", port: targetPort }
);

const runningServer = getRunningServer(server);
const { stop, endpoint } = runningServer;
// const runningServer = getRunningServer(server);
const { url: endpoint } = server;

// Shut down the server if somebody kills the process
process.on("SIGINT", async () => {
await stop();
console.log(`${name}: Stopped`);
});
// process.on("SIGINT", async () => {
// await stop();
// console.log(`${name}: Stopped`);
// });

console.log(`${name}: Ready at ${endpoint.hostname}:${endpoint.port}`);
console.log(`${name}: Ready at ${endpoint}`);

return runningServer;
return {
endpoint: { hostname: stubbyEndpoint.hostname, port: stubbyEndpoint.port },
stop: async () => console.log("non-working function!"),
};
}
7 changes: 3 additions & 4 deletions packages/integration/src/startStubby.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { getEndpoint } from "./getEndpoint";
*/

export async function startStubby({
targetPort,
targetPort, // 0
}: {
targetPort: TargetPort;
}): Promise<RunningServer> {
Expand All @@ -37,12 +37,11 @@ export async function startStubby({
fs.readFileSync(path.join(__dirname, "stubbyData.yml"), "utf8")
) as StubbyData,
},
(err) => (err ? reject(err) : resolve())
(err) => (err ? reject(`${err}`) : resolve("nay error"))
)
);

const stop = promisify(stubby.stop).bind(stubby);

const stop = promisify(stubby.stop).bind(stubby);
process.on("SIGINT", async () => {
await stop();

Expand Down
9 changes: 6 additions & 3 deletions packages/integration/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@
// tests if we transpile to es5. Because we're running Node 6+, it's safe
// to target es2016. For more info, see
// https://github.com/apollographql/apollo-server/issues/1388.
"target": "es2016",
"target": "ESNext",
"esModuleInterop": true,

"module": "commonjs",
"module": "CommonJS",
"moduleResolution": "node",

// Typescript is only used for type-checking in the integration
// environment, not code generation. Jest executes the code at runtime.
"noEmit": true
"noEmit": true,
"noUnusedLocals": false
},

"include": ["src"]
Expand Down
Loading
Loading