Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme設定 #9

Merged
merged 21 commits into from
Feb 26, 2024
Merged

Theme設定 #9

merged 21 commits into from
Feb 26, 2024

Conversation

KobayashiYoh
Copy link
Collaborator

@KobayashiYoh KobayashiYoh commented Feb 25, 2024

概要

現段階のFigmaを参考に、main.dartでThemeの設定を行いました

UI(DebugPage)

UI(DebugTextThemePage)

@KobayashiYoh KobayashiYoh changed the title Feature/styles Theme設定 Feb 25, 2024
@KobayashiYoh KobayashiYoh marked this pull request as ready for review February 25, 2024 12:08
Copy link
Collaborator

@Yoshida-koshi Yoshida-koshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました〜

static const Color gray1 = Color(0xFF222222);
static const Color gray2 = Color(0xFF353535);
static const Color gray3 = Color(0xFF828282);
static const Color gray4 = Color(0xFFDBDBDB);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figmaでは#BDBDBDだけど、#DBDBDBでも色変わらないのかな?

スクリーンショット 2024-02-26 17 25 41

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとー
全部僕の見間違いというかケアレスミスだから全部修正するね

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

カラーコード修正しました
a91b431

static const Color gray2 = Color(0xFF353535);
static const Color gray3 = Color(0xFF828282);
static const Color gray4 = Color(0xFFDBDBDB);
static const Color gray5 = Color(0xFFE6E4E7);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも若干違うけど、色変わらないのかな?

スクリーンショット 2024-02-26 17 28 03

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これも僕の見間違い

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これも修正
a91b431

static const Color gray6 = Color(0xFFF2F2F2);

static const Color gray1A80 = Color(0xCC222222);
static const Color gray5A80 = Color(0xCCE6E4E7);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも若干違うなぁ

スクリーンショット 2024-02-26 17 32 46

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これも僕の見間違い

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これも修正
a91b431

@KobayashiYoh KobayashiYoh self-assigned this Feb 26, 2024
@Yoshida-koshi
Copy link
Collaborator

LGTM!

@Yoshida-koshi Yoshida-koshi merged commit adcd5a2 into develop Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants