Add missing changes in the generated buildRun CRD #253
Conversation
|
/assign @xiujuan95 |
|
@qu1queee: GitHub didn't allow me to assign the following users: xiujuan95. Note that only redhat-developer members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
the
ok-to-test
- Add missing spec.output declaration in the buildrun. I think this was missing in shipwright-io#233 - Add missing timeout in spec.status.buildSpec, I think this was missed somehow after shipwright-io#158 was merged. Also, this can be reproduced by doing `operator-sdk generate crds`
qu1queee
force-pushed
the
qu1queee/fix-buildrun-crd
branch
from
a92f7ac to
75095ad
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhangtbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
…io#253) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | centos | final | major | `7` -> `8` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41NS4yLXJwbSIsInVwZGF0ZWRJblZlciI6IjM4LjU1LjItcnBtIiwidGFyZ2V0QnJhbmNoIjoiYnVpbGRzLTEuMSIsImxhYmVscyI6W119-->
this was missing in Add image tag definition in buildrun spec #233
somehow after Add timeout setting to build and buildrun #158 was merged.
Also, this can be reproduced by doing
operator-sdk generate crds