-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow buildRun to support buildSpec to enable one-shot builds #929
feat: Allow buildRun to support buildSpec to enable one-shot builds #929
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jaideepr97: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jaideepr97 this pull request needs to rebase. Are you still working on this? |
Hey @adambkaplan, I haven't been working on this |
/close @jaideepr97 based on further community discussion, we need additional input from the community (via a SHIP) before proceeding further on this feature. We're therefore closing this pull request. |
@adambkaplan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
This is a WIP proof of concept PR to support embedding
buildSpec
directly into abuildRun
which would allow users to create a one-shot build and reduce the process to a single-step process, without having to first create abuild
object and then reference it from abuildRun
objectThis involves updating
buildRef
to be an optional field now, and introducingbuildRun.spec.buildSpec
Each
buildRun
must specify exactly 1 of eitherbuildRun.spec.buildRef
orbuildRun.spec.buildSpec
, and may not provide any overrides if defining a new buildSpec within the buildRunFixes #677
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Example one-shot
buildRun
: